Re: [PATCH] cy8ctmg110: capacitive touchscreen support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 09, 2010 at 09:27:05AM -0700, Dmitry Torokhov wrote:
> On Fri, Jul 09, 2010 at 04:36:32PM +0100, Alan Cox wrote:
> > From: Samuli Konttila <samuli.konttila@xxxxxxxxxxxxxx>
> > 
> > Add support for the cy8ctmg110 capacitive touchscreen used on some embedded
> > devices.
> > 
> > (Some clean up by Alan Cox)
> > 
> > - Moved the hardcoded GPIO lines into platform data
> > 
> 
> I still see GPIO lines hardcoded. Wrong changeset description?
> 
> > +
> > +	hrtimer_init(&ts->timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
> > +	ts->timer.function = cy8ctmg110_timer;
> > +
> 
> I doubt it compiles since you seem to have removed cy8ctmg110_timer().
> 

Ah, see you sent the next version, ignore me then.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux