On Thu, Jul 01, 2010 at 10:15:11AM +0100, Hennerich, Michael wrote: > Dmitry Torokhov wrote on 2010-07-01: > > On Fri, Jun 25, 2010 at 02:59:24PM +0100, Hennerich, Michael wrote: > >> Dmitry Torokhov wrote on 2010-06-25: > >>> Hi Mike, Michael, > >>> > >>> On Tue, Oct 20, 2009 at 04:40:39AM -0400, Mike Frysinger wrote: > >>>> From: Michael Hennerich <michael.hennerich@xxxxxxxxxx> > >>>> > >>>> This is a driver for the ADXL345/346 Three-Axis Digital > >>>> Accelerometers. > >>>> > >>> > >>> As I mentioned in one of the threads I decided to pull 3-axis > >>> acceleromenetrs into input and I am finally getting around to > >>> apply the patch... However I messed a bit with it so I was > >>> wondering if someone could give it a short spin to see if I broke it or not. > >>> > >>> Thanks! > >>> > >> > >> Hi Dmitry, > >> > >> Thanks for merging this driver. > >> I gave it a quick spin. And there is one issue. > >> There is a code path that is taken with the mutex held, which is > >> also trying to acquire the mutex. > >> > >> Take a look at > >> > >> adxl34x_input_close() -> __adxl34x_disable() or > >> adxl34x_disable() -> __adxl34x_disable() > >> > >> I think __adxl34x_disable() should not acquire the mutex! > >> > > > > Yes, indeed it shoudl not have. I fixed it up and applied the patch. > > Could you also please try the following patch - hopefully it also works > > ;) > > > > Thank you in advance. > > > > Hi Dmitry, > > A few minor things. > See patch below. > > -adxl34x is on startup not disabled - otherwise user must reset disable sysfs > hook before the driver delivers any data. > -restore erroneously dropped line in adxl34x_calibrate_store() > -fix typo in adxl34x-i2c.c (l versus 1) > Folded and applied, thank you Michael. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
