On Friday, June 25, 2010 04:22:24 Dmitry Torokhov wrote: > From: Mike Frysinger <vapier@xxxxxxxxxx> > > The ad7879 driver is using the old bus method of only supporting one at a > time (I2C or SPI). So refactor it like the other input drivers that > support multiple busses simultaneously. > > Signed-off-by: Mike Frysinger <vapier@xxxxxxxxxx> > Signed-off-by: Michael Hennerich <michael.hennerich@xxxxxxxxxx> > Signed-off-by: Dmitry Torokhov <dtor@xxxxxxx> > --- > > drivers/input/touchscreen/ad7879-i2c.c | 140 +++++++++ > drivers/input/touchscreen/ad7879-spi.c | 190 ++++++++++++ > drivers/input/touchscreen/ad7879.c | 495 > +++++++------------------------- drivers/input/touchscreen/ad7879.h | > 30 ++ > 4 files changed, 461 insertions(+), 394 deletions(-) > create mode 100644 drivers/input/touchscreen/ad7879-i2c.c > create mode 100644 drivers/input/touchscreen/ad7879-spi.c > create mode 100644 drivers/input/touchscreen/ad7879.h i think you forgot the Kconfig and Makefile changes. without those, the driver cannot be configured/compiled correctly. i also see you changed the code from passing a struct device pointer to a struct ad7879 pointer. i went with the struct device because it generated smaller code due to pushing down of the dev get/set drvdata. the i2c struct sucks because it doesnt stick its dev member at the start of the structure. -mike
Attachment:
signature.asc
Description: This is a digitally signed message part.
