Hi, Dmitry Did Xiaolong's answer satisfy you? A formal patch (non-RFC) patch was sent and compile option was removed. Let us know whether you have more comments -- Best Regards Hu Tao On Thu, Jun 17, 2010 at 3:33 PM, Xiaolong CHEN <xiao-long.chen@xxxxxxxxxxxx> wrote: > Hi Dmitry, > > Sorry for the late, I'm on vacation these days. > > 1. Why did you go with a compile option? > It's easy to use on different target board, sometimes the adp5588 will > not used for switch events. > > Is it possible to enable this functionality unconditionally and let > board setup code specify what it wants to use? > Yes, I think it should be ok if checking the parameter. > > 2. Why did you decide to make the events switches and not keys? > Do you mean why use input_report_switch in this patch? Since a target > board might need a switch (for example: slider switch, slience > switch), and it will report to the user space. Also, it's not > economical to report a key event by GPI event, one pin could report > one event, but if use one pin in key matrix, it could report > 1xrow/1xcol events. > > Thanks, > Xiaolong > > On Fri, Jun 11, 2010 at 3:28 AM, Dmitry Torokhov > <dmitry.torokhov@xxxxxxxxx> wrote: >> >> Hi Xiaolong, >> >> On Wednesday, June 09, 2010 07:36:14 pm Xiaolong CHEN wrote: >> > Hi, >> > >> > This patch supports GPI event for ADP5588 devices. >> > >> > Kernel Version: 2.6.34 >> > >> > A column or row configured as a GPI can be programmed to be part of >> > the key event table and therefore also capable of generating a key >> > event interrupt. A key event interrupt caused by a GPI follows the >> > same process flow as a key event interrupt caused by a key press. GPIs >> > configured as part of the key event table allow single key switches >> > and other GPI interrupts to bemonitored. As part of the event table, >> > GPIs are represented by the decimal value 97 (0x61or 1100001) through >> > the decimal value 114 (0x72 or 1110010). See Table as below for GPI >> > event number assignments for rows and columns. >> > >> > GPI Event Number Assignments for Rows >> > Row0 Row1 Row2 Row3 Row4 Row5 Row6 Row7 >> > 97 98 99 100 101 102 103 104 >> > >> > GPI Event Number Assignments for Cols >> > Col0 Col1 Col2 Col3 Col4 Col5 Col6 Col7 Col8 Col9 >> > 105 106 107 108 109 110 111 112 113 114 >> > >> > Usage: >> > 1. Enable CONFIG_KEYBOARD_ADP5588_GPI_EVENT >> > 2. Add gpimap and gpimapsize setting in adp5588_kpad_platform_data >> > (The settings should not conflict with rows/cols for keymap) >> >> A couple of questions: >> >> 1. Why did you go with a compile option? Is it possible to enable this >> functionality unconditionally and let board setup code specify what >> it wants to use? >> >> 2. Why did you decide to make the events switches and not keys? >> >> Thanks. >> >> -- >> Dmitry > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
