Hello, On Monday, June 21, 2010 11:06 AM Eric Miao wrote: > On Mon, Jun 21, 2010 at 2:26 PM, Joonyoung Shim <jy0922.shim@xxxxxxxxxxx> > wrote: > > This patch adds samsung keypad device definition for samsung cpus. > > > > Signed-off-by: Joonyoung Shim <jy0922.shim@xxxxxxxxxxx> > > Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> > > --- > > arch/arm/plat-samsung/Kconfig | 5 ++ > > arch/arm/plat-samsung/Makefile | 1 + > > arch/arm/plat-samsung/dev-keypad.c | 58 > +++++++++++++++++++++ > > Why need an individual file for a simple device? In the end, these files > will flood over the plat-samsung/ directory. And now think this - in your > new SoC design ,the keypad IP is replaced with a completely new one, does > that mean a new dev-keypad-new1.c, dev-keypad-new2.c? > > I personally prefer a single devices.c for all the devices, if you > orgnize well, shouldn't take up much code size in that single file. A separate dev-abc.c files has been chosen by a platform maintainer. This has some advantages as some unused data can be easily not compiled into the kernel which is configured specially for a particular board. Best regards -- Marek Szyprowski Samsung Poland R&D Center -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
