Andrew
Actually this patch should go into udev. udev now handles keyreleasing.
drivers/input/keyboard/atkbd.c is to no longer take fixes like this.
There is a rule in udev 95-keyboard-force-release.rules .. you just
need to add these machines. There is a file common-volume-keys you would
have run for these machines .. you'll see other machines in the rules
file with the same fix.
Jerone
On Fri, 2010-06-18 at 14:32 +0200, Jiri Kosina wrote:
> On Wed, 9 Jun 2010, Andrew Kohlsmith wrote:
>
> > Good afternoon,
> >
> > Here is a small patch which adds a quirk match for these laptops; the volume
> > wheel on them does not stop when you move it (the wheel does not send 'up'
> > keycodes).
> >
> > Patch applies cleanly to linus' tree as of about...10 minutes ago. :-)
>
> Hi Andrew,
>
> this patch needs to go through Dmitry, who is current input subsystem
> maintainer.
>
> I have added him (and linux-input) to CC, and included the patch for
> convenience below.
>
> You'd also need to include your Signed-off-by: line in order for the patch
> to be properly merged.
>
> Thanks.
>
>
>
> diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
> index d358ef8..f1e1801 100644
> --- a/drivers/input/keyboard/atkbd.c
> +++ b/drivers/input/keyboard/atkbd.c
> @@ -1715,6 +1715,22 @@ static const struct dmi_system_id atkbd_dmi_quirk_table[] __initconst = {
> .callback = atkbd_setup_scancode_fixup,
> .driver_data = atkbd_oqo_01plus_scancode_fixup,
> },
> + {
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Satellite U300"),
> + },
> + .callback = atkbd_setup_forced_release,
> + .driver_data = atkbd_volume_forced_release_keys,
> + },
> + {
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Satellite Pro U300"),
> + },
> + .callback = atkbd_setup_forced_release,
> + .driver_data = atkbd_volume_forced_release_keys,
> + },
> { }
> };
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
