On Thu, Jun 17, 2010 at 8:14 AM, Andy Walls <awalls@xxxxxxxxxxxxxxxx> wrote: > On Wed, 2010-06-16 at 16:41 -0400, Jarod Wilson wrote: >> On Wed, Jun 16, 2010 at 4:04 PM, Jarod Wilson <jarod@xxxxxxxxxxxx> wrote: >> ... >> >> I have another suggestion, let's keep the client register/unregister >> >> callbacks for decoders (but add a comment that they're only used for >> >> lirc). Then teach drivers/media/IR/ir-raw-event.c to keep track of the >> >> raw clients so that it can pass all pre-existing clients to newly added >> >> decoders. >> >> >> >> I'll post two patches (compile tested only) in a few seconds to show >> >> what I mean. >> > >> > Consider them now runtime tested as well. They appear to do the trick, >> > the lirc bridge comes up just fine, even when ir-lirc-codec isn't >> > loaded until after mceusb. *Much* better implementation than my ugly >> > trick. I'll ack your patches and submit a series on top of them for >> > lirc support, hopefully this evening (in addition to a few other fixes >> > that aren't dependent on any of them). >> >> A fully functional tree carrying both of David's patches and the >> entire stack of other patches I've submitted today, based on top of >> the linuxtv staging/rc branch, can be found here: >> >> http://git.wilsonet.com/linux-2.6-ir-wip.git/?a=shortlog;h=refs/heads/patches >> >> Also includes the lirc patches that I believe are ready to be >> submitted for actual consideration (note that they're dependent on >> David's two patches). > > > I'll try and play with this this weekend along with some cx23885 > cleanup. Excellent. A few things to note... Many of the lirc_dev ioctls are currently commented out, and haven't in any way been wired up to tx callbacks, I've only enabled the minimum necessary for mceusb. The ioctls are all using __u32 params, which, if you're on x86_64, will require a patched lirc userspace build to make the ioctl types match. I'm using this patch atm: http://wilsonet.com/jarod/lirc_misc/lirc-0.8.6-make-ioctls-u32.patch (In the future, lirc userspace should obviously just build against <media/lirc.h>). -- Jarod Wilson jarod@xxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
