* Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> [100601 23:07]: > On Tue, Jun 01, 2010 at 09:53:58PM +0300, Felipe Balbi wrote: > > On Tue, Jun 01, 2010 at 05:14:09PM +0200, ext Arce, Abraham wrote: > > >I am using #ifdef CONFIG_ARCH_OMAP4 for this portion of code, what > > >you are suggesting is to check at runtime? > > > > you need to add both checks. If you build omap3-only or omap2-only > > you don't want that code to be compiled, but if you build > > omap1-2-3-4 kernel, you want it to work correctly on all cases. > > > > It sould be nice if cpu_is_xxx were stubbed out for "wrong" arches > withing the same group (like omap, etc) so we could reduce the #ifdef > clutter. They are defined as stubs for for non-selected omaps. So in general a function doing this in the beginning of the function: if (!cpu_is_omap44xx()) return -ENODEV; Should already get optimized out if 44xx is not selected in Kconfig. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
