On Mon, Jun 07, 2010 at 03:13:42PM +0200, Oliver Neukum wrote: > static int usbtouch_open(struct input_dev *input) > { > struct usbtouch_usb *usbtouch = input_get_drvdata(input); > + int r; > > usbtouch->irq->dev = interface_to_usbdev(usbtouch->interface); > > + r = usb_autopm_get_interface(usbtouch->interface) ? -EIO : 0; Why are we clobbering error code with -EIO? We should propagate te code returned to us (here and below). Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html