Re: [PATCH v2 1/5] ARM: SAMSUNG: Add keypad device support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, May 30, 2010 at 05:42:37AM +0200, Marek Vasut wrote:
> Dne Ne 30. května 2010 05:06:20 Joonyoung Shim napsal(a):
> > + */
> > +struct samsung_kp_platdata {
> > +	const struct matrix_keymap_data	*keymap_data;
> > +	unsigned int		rows;
> > +	unsigned int		cols;
> > +	unsigned int		rep;
> 
> I don't know, maybe using uint32_t here? On ARM, it doesn't matter so far as int 
> will be always 32bit, but maybe we should just type the variables well ?
> 
> Guys, what do you think ?
> 

I think unsigned int is fine, we do not care about particular size, just
need "big enough". I'd change 'rep' to be a boolean though.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux