On Wednesday, May 19, 2010 8:46 AM, Hennerich, Michael wrote:
> H Hartley Sweeten wrote on 2010-05-19:
>> On Wednesday, May 19, 2010 3:01 AM, Michael Hennerich wrote:
>>> Similar patch as reported by Oskar Schirmer <os@xxxxxxxxx> for the
>>> AD7877.
>>>
>>> With no word size given in the users platform data, a generic spi host
>>> controller driver will assume a default word size of eight bit. Ensure
>>> spi->bits_per_word is set for 16-bit transfers.
>>>
>>> Signed-off-by: Michael Hennerich <Michael.hennerich@xxxxxxxxxx>
>>> ---
>>> drivers/input/touchscreen/ad7879.c | 10 ++++++++++
>>> 1 files changed, 10 insertions(+), 0 deletions(-)
>>> diff --git a/drivers/input/touchscreen/ad7879.c
>>> b/drivers/input/touchscreen/ad7879.c
>>> index 794d070..ff490c0 100644
>>> --- a/drivers/input/touchscreen/ad7879.c
>>> +++ b/drivers/input/touchscreen/ad7879.c
>>> @@ -715,6 +715,16 @@ static int __devinit ad7879_probe(struct
>>> spi_device
>>> *spi)
>>> return -EINVAL;
>>> }
>>> + if (spi->bits_per_word != 16) {
>>
>> The master never sets this field so this test isn't needed. The
>> platform specific spi_board_info "could" set the field but I don't
>> think any currently do.
>
> Blackfin does!
> Originally my assumption was that everyone does it - that's why this
> haven't been fixed earlier.
Hmm... It appears they do ;-)
But, it's passed as controller_data that would be specific to the Blackfin
spi master driver.
Regards,
Hartley--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
