On Wed, May 12, 2010 at 07:15:22PM +0100, Jonathan Cameron wrote: > Hi, > > I was wondering if you could provide a bit more detail on what this > driver is actually doing? My appologies if I have missed a > previous explanation. If so, please add a Documentation file > to explain what is going on. > > The driver you have here does virtually nothing itself. It takes > both its source of interrupt and read function from platform > data. Given the value is always 0 or 1, I'm guessing you are > simply reading a gpio pin. That makes this effectively a button > and doesn't require any specific code. The fact it is a > proximity sensor isn't relevant to anything other than perhaps > the name. Excellent point. Maybe it should simply use gpio_keys driver with SW_FRONT_PROXIMITY code. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
