On Tue, May 11, 2010 at 12:03:44AM -0500, Arce, Abraham wrote: > Hi again Dmitry, > > > No worries, although at first I was surprised that Trilok spoke exactly > > the same words I did ;) > > > > :) > > > > > > > + > > > > > > +/* Interrupt thread handler thread */ > > > > > > + > > > > > > +static irqreturn_t omap_keypad_threaded(int irq, void *dev_id) > > > > > > +{ > > > > > > > > > > Why is iti threaded? I fo not see anything that will sleep. > > > > > > > > > It was implemented based on previous comments... > > > > > > > Would you point me to that comment? Like I said, I do not see anything > > that would possibly sleep in this routine so you don't need to use > > threaded interrupt. > > http://www.mail-archive.com/linux-omap@xxxxxxxxxxxxxxx/msg26352.html > Thanks. I think Kevin meant "use theaded IRQ, wherever possible" [if we need to sleep in interrupt handler]. Adding him to CC. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html