Re: [PATCH 2/2 v3] elantech: Report multitouch with proper ABS_MT messages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Op 10-05-10 22:53, Henrik Rydberg schreef:
> Hi again Éric,
> 
> thanks for your changes, the first patch looks better now. However, both patches
> still have style problems. Also, the second patch now makes unrelated changes to
> the ABS_X etc, so it is difficult to even know what was tested, and whether the
> first patch really works as claimed.
What are the style problems of the first patch? I tried to fix all of them.

Concerning the second patch, it's necessary to change the lines with
ABS_X, because otherwise the computation would be duplicated for the MT
part and it would make everything look more complicated. Honestly, I
think this change is still very limited and can easily be reviewed for
not changing the semantic. Well, I think it would be a bit overkill, but
if really considered necessary, I can do a third intermediary patch...
Dmitry let me know if you can merge the patch as is.

Eric

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux