On Wed, Apr 28, 2010 at 01:41:12PM -0700, Dmitry Torokhov wrote: > On Wed, Apr 28, 2010 at 01:37:00PM -0400, Jarod Wilson wrote: > > Set the EV_REP bit, so reported key repeats actually make their > > way out to userspace, and fix up the handling of repeats a bit, > > routines for which are shamelessly heisted from ati_remote2.c. > > > > Is it really needed? I'd expect input core handling auto-repeating > for you as long as you set EV_REP flag. In my own (albeit brief) testing, the heisted bits don't make a significant difference, but I had a user say that it helped a bit at suppressing what he perceived as extraneous repeats being passed through. In reality, setting a slightly higher rep delay or rep period might be the better answer here. Actually, I think I know exactly what was happening for said user. He's using a device that only supports mce mode, where these devices don't have a release code, they're timer-based, I think the repeat timeout of 200ms was triggering an auto-repeat every 33ms for 200ms, thus giving the appearance of way more repeats than the hardware actually sent. Okay, lemme rework this patch a bit, I think I can drop all that heisted crud, and simply bumping the release timer in mce mode by rep period ms instead of 200ms for repeats should be sufficient. Need to get my imon device that supports both imon and mce proto back into a state where I can use it for testing... -- Jarod Wilson jarod@xxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
