On Wed, Apr 21, 2010 at 10:35:37AM -0600, Bjorn Helgaas wrote: > On Wednesday 21 April 2010 02:10:48 am Dmitry Torokhov wrote: > > @@ -169,11 +182,17 @@ static int __init pnpacpi_add_device(struct acpi_device *device) > > * driver should not be loaded. > > */ > > status = acpi_get_handle(device->handle, "_CRS", &temp); > > - if (ACPI_FAILURE(status) || !ispnpidacpi(acpi_device_hid(device)) || > > - is_exclusive_device(device) || (!device->status.present)) > > + if (ACPI_FAILURE(status)) > > + return 0; > > + > > + pnpid = pnpacpi_get_id(device); > > + if (!pnpid) > > + return 0; > > I think this makes sense, but I think we should also adjust the loop > at the end of pnpacpi_add_device() that adds all the CIDs. As it > currently works, I think your patch will cause this device to have > two copies of the CID, e.g., > > PNP0F13 PNP0F13 > Yep, you are right. I will adjust it after I hear from Jan whether it fixes his issue. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
