Hi Dmitry,
At Mon, 19 Apr 2010 01:32:22 -0700,
Dmitry Torokhov wrote:
>
> Hi Takashi,
>
> On Wed, Apr 14, 2010 at 05:10:22PM +0200, Takashi Iwai wrote:
> > Add the detection of Synaptics Clickpad device.
> > The device can be detected a new query command 0x0c. The clickpad
> > flags are in cap[0]:4 and cap[1]:0 bits. But, the driver checks
> > first the product id bits in the ext capabilities to be sure, so
> > that it skips the new check on older devices.
> >
>
> Instead of looking at the product id, can we check the number of
> supported extended capabilities queries and act accordingly, like the
> patch below?
Yes, it worked. (Though, I've tested only new machines.)
> @@ -162,6 +163,16 @@ static int synaptics_capability(struct psmouse *psmouse)
> priv->ext_cap &= 0xff0fff;
> }
> }
> +
> + if (SYN_EXT_CAP_REQUESTS(priv->capabilities) >= 4) {
> + if (synaptics_send_cmd(psmouse, SYN_QUE_EXT_CAPAB_0C, cap)) {
> + printk(KERN_ERR "Synaptics claims to have extended capability 0x0c,"
> + " but I'm not able to read it.");
Here missing a newline, BTW.
thanks,
Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
