On Sat, Apr 17, 2010 at 01:27:05AM +0400, Manu Abraham wrote: > On Sat, Apr 17, 2010 at 12:56 AM, David Härdeman <david@xxxxxxxxxxx> wrote: > > On Fri, Apr 16, 2010 at 03:17:35AM +0400, Manu Abraham wrote: > >> On Fri, Apr 16, 2010 at 1:46 AM, David Härdeman <david@xxxxxxxxxxx> wrote: > >> > Convert drivers/media/dvb/mantis/mantis_input.c to not use ir-functions.c > >> > (The driver is anyway not complete enough to actually use the subsystem yet). > >> > >> Huh ? I don't follow what you imply here .. > >> > > > > The mantis_input.c file seems to be a skeleton as far as I could > > tell...not actually in use yet. Or am I mistaken? > > Only the input related parts of the IR stuff is there in > mantis_input.c, the hardware handling is done by mantis_uart.c/h. > There is a small bit which has not gone upstream yet, which is > pending; > http://jusst.de/hg/mantis-v4l-dvb/rev/ad8b00c9edc2 > Yes, and that patch includes actually calling mantis_input_init(), which wasn't called previously, so mantis_input.c wasn't actually in use. Anyways, my patch still applies (or the principle at least) - use the functionality of ir-core and not ir-functions.c (which is going away). And on a related note, the above patch adds keytables with entries like KEY_0, they should probably be KEY_NUMERIC_* instead. -- David Härdeman -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
