Andy Walls wrote: > On Thu, 2010-04-08 at 13:39 +0200, David Härdeman wrote: > Encoding pulse vs space with a negative sign, even if now hidden with > macros, is still just using a sign instead of a boolean. Memory in > modern computers (and now microcontrollers) is cheap and only getting > cheaper. Don't give up readability, flexibility, or mainatainability, > for the sake of saving memory. Btw, a bad side effect of using the negative sign is that enabling debug will present those messages, showing negative number of units and time to the poor user: [42889.320163] ir_rc5_decode: RC5(x) decode started at state 1 (-1 units, -816us) [42889.320166] ir_rc6_decode: RC6 decode started at state 0 (-2 units, -816us) [42889.320169] ir_rc6_decode: RC6 decode failed at state 0 (-2 units, -816us) It seems we need a debug macro also. -- Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
