Andy Walls wrote:
> On Fri, 2010-04-02 at 19:39 -0400, Andy Walls wrote:
>> On Thu, 2010-04-01 at 14:56 -0300, Mauro Carvalho Chehab wrote:
>
>>> +enum raw_event_type {
>>> + IR_SPACE = (1 << 0),
>>> + IR_PULSE = (1 << 1),
>>> + IR_START_EVENT = (1 << 2),
>>> + IR_STOP_EVENT = (1 << 3),
>>> +};
>>> +
>> Why are these events encoded as bit flags? Shouldn't they all be
>> orthogonal?
> ^^^^^^^^^^
> Argh, wrong word.
Why is it wrong? It seems appropriate to me.
>
> Shouldn't they all be mutually exclusive?
space x pulse are mutually exclusive, and start x stop are also
mutually exclusive, but you may have several possible combinations
for an event. The hole set of possibilities are:
IR_SPACE
IR_PULSE
IR_SPACE | IR_START_EVENT
IR_SPACE | IR_STOP_EVENT
IR_PULSE | IR_START_EVENT
IR_PULSE | IR_STOP_EVENT
With bit flags, it is possible to cover all the above combinations.
In a matter of fact, the driver is currently not using the stop events.
--
Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
