Re: Merge plans for Staging Synaptics Touchscreen Driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>> Hi!
>>
>>> Are there any plans to merge the synaptics touchscreen driver
>>> (drivers/staging/dream/synaptics_i2c_rmi.c) to
>>> drivers/input/touchscreen. We are interested in the same
>>> since OMAP3 based Zoom boards use this touchscreen.
>>
>> Plans are, but day job interferes with them.
>>
>>> Pl add (if required) below tested by for the staging driver.
>
>>
>> 1) are you able to use driver in staging?
>
> Yes I am able to use staging driver for single
> touch events.
>
>>
>> at minimum, non-standard multitouch support needs to be removed before
>> merging to input. Do you have time to help?
>
> Could you review the below patch.

Forgot to remove unused variables in earlier patch, here's
the updated one.


---

Remove non-standard multi touch support.

Signed-off-by: Hemanth V <hemanthv@xxxxxx>

diff --git a/drivers/staging/dream/synaptics_i2c_rmi.c b/drivers/staging/dream/synaptics_i2c_rmi.c
index 4de6bc9..f3bc7d6 100644
--- a/drivers/staging/dream/synaptics_i2c_rmi.c
+++ b/drivers/staging/dream/synaptics_i2c_rmi.c
@@ -108,9 +108,6 @@ static void decode_report(struct synaptics_ts_data *ts, u8 *buf)
 	int f, a;
 	int base = 2;
 	int z = buf[1];
-	int w = buf[0] >> 4;
-	int finger = buf[0] & 7;
-	int finger2_pressed;

 	for (f = 0; f < 2; f++) {
 		u32 flip_flag = SYNAPTICS_FLIP_X;
@@ -150,14 +147,6 @@ static void decode_report(struct synaptics_ts_data *ts, u8 *buf)
 		input_report_abs(ts->input_dev, ABS_Y, pos[0][1]);
 	}
 	input_report_abs(ts->input_dev, ABS_PRESSURE, z);
-	input_report_abs(ts->input_dev, ABS_TOOL_WIDTH, w);
-	input_report_key(ts->input_dev, BTN_TOUCH, finger);
-	finger2_pressed = finger > 1 && finger != 7;
-	input_report_key(ts->input_dev, BTN_2, finger2_pressed);
-	if (finger2_pressed) {
-		input_report_abs(ts->input_dev, ABS_HAT0X, pos[1][0]);
-		input_report_abs(ts->input_dev, ABS_HAT0Y, pos[1][1]);
-	}
 	input_sync(ts->input_dev);
 }




--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux