On Sat, Mar 20, 2010 at 05:04:15PM +0100, Bruno Prémont wrote: > +static inline int picolcd_fb_send_tile(struct hid_device *hdev, int chip, > + int tile) > +{ You seemt o be fond of the 'inline; attribute ;) I don't think that a 40 lines function qualifies. Please lose inlines on functions that are not in .h files and are not stubs. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html