On Fri, Mar 19, 2010 at 03:23:23PM +0000, Matthew Garrett wrote: > On Fri, Mar 19, 2010 at 11:10:54PM +0800, Yong Wang wrote: > > On Fri, Mar 19, 2010 at 01:59:29PM +0000, Matthew Garrett wrote: > > > > > > This probably ought to use the new sparse keymap code. I know that there > > > are drivers that are currently in the tree that don't, but it's probably > > > preferable to avoid adding new ones. > > > > > > > OK, will take a look at the new interface and revise accordingly. > > Wonderful, thanks. > You are welcome. > > > > + if (code >= NOTIFY_BRNUP_MIN && code <= NOTIFY_BRNUP_MAX) > > > > + code = NOTIFY_BRNUP_MIN; > > > > + else if (code >= NOTIFY_BRNDOWN_MIN && code <= NOTIFY_BRNDOWN_MAX) > > > > + code = NOTIFY_BRNDOWN_MIN; > > > > > > Do the brightness keys just send notifications, or do they actually > > > change the brightness? If they actually change the brightness, we > > > shouldn't send input events. > > > > > > > Yes, hardware and bios change brightness by themselves without software intervention > > on my Eee PC 1005 when pressing the hotkeys. > > Ok. In that case, you shouldn't send input events. Once backlight > control is implemented in the eee-wmi driver you can send notifications > via that instead. > Got it. Backlight is on my TODO list and I plan to add those features incrementally so that people could starting playing with it asap since I've only got a 1005 and I am not sure how it works on other make and models. Make sense? -Yong -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
