Re: [RFC/RFT 3/5] USB: usbtouch: Prevent possible deadlock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Sonntag, 14. März 2010 09:59:49 schrieb Dmitry Torokhov:
> > For autosuspend memory in suspend/resume must be allocated with
> > GFP_NOIO.
> 
> I'd prefer if this change was folded into previous patch - there was no
> deadlock condition before you added reset_resume.

Rafael is working on automatically going to GFP_NOIO in case the system
is resumed. The change will be needed for patch #4, not #2.
 
> > @@ -806,19 +806,19 @@ static int nexio_init(struct usbtouch_usb *usbtouch)
> >       /* prepare ACK URB */
> >       ret = -ENOMEM;
> >  
> > -     usbtouch->priv = kmalloc(sizeof(struct nexio_priv), GFP_KERNEL);
> > +     usbtouch->priv = kmalloc(sizeof(struct nexio_priv), GFP_NOIO);
> >       if (!usbtouch->priv)
> >               goto out_buf;
> >  
> 
> Remind me, how does ->exit() gets called in case of reset_resume?
> Otherwise it looks like ne are leaking memory...

Oh, I overlooked that they only free buf, not priv. I'll have to add a hook.

	Thanks
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux