No problem, this patch had a meaning only with the 2 others Micheal
already reviewed.
The core idea of the series of patch was to register the fields in the
newly created report in order to having two benefits:
- use the input created by hid-input (not required anymore as you
integrated Michael's patch) and suppress the second input created by
hand (this is why the patch n°3 named "HID: deletion of unused code in
hid-magicmouse" suppress everything related to this input)
- recreate the fields in the report descriptor in order to avoid using
the raw event in a later patch.
I have now to look on how can we register fields in a report that are
non mandatory. Michael told me that he did not found it too.
After that, I will probably resend a better patch.
Cheers,
Benjamin
Le 10/03/2010 16:09, Jiri Kosina a écrit :
On Mon, 8 Mar 2010, Benjamin Tissoires wrote:
Well ... I don't see any patch titled "HID: deletion of unused code in
hid-magicmouse" neither in my inbox nor in my linux-input@ folder. Could
you perhaps please resend?
Thanks,
Of course, I attached it. Do I need to send it in mbox format or is it ok ?
Well, magicmouse_setup_input() is actually used from inside the probe
routine, so we'd rather not remove it.
I have already merged Michael's patch with calls hid_hw_start() with
HID_CONNECT_HIDINPUT flag cleared out, so the registration of the input
device is now performed properly.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
