On Tue, Mar 09, 2010 at 04:27:48PM -0500, Mike Frysinger wrote: > On Tue, Mar 9, 2010 at 16:21, Dmitry Torokhov wrote: > > On Tue, Mar 09, 2010 at 04:01:53PM -0500, Mike Frysinger wrote: > >> From: Bryan Wu <cooloney@xxxxxxxxxx> > >> > >> Signed-off-by: Bryan Wu <cooloney@xxxxxxxxxx> > >> Signed-off-by: Mike Frysinger <vapier@xxxxxxxxxx> > >> --- > >> v2 > >> - process all feedback from Dmitry except for threaded irqs; that'll have to be done later > > > > Could I ask why? As it stands the remove() is racy WRT to a work > > running. But if you simply add cancel_work_sync() you'll risk leaving > > unbalanced enable_irq()/disable_irq(). > > ive never worked with threaded irq handlers before. i'll have to read > about them before i can do the work. i'm not suggesting you take the > driver now as is ... having it on a list in case someone else wants a > mostly-ok driver. It is very simple, take a look at drivers/input/touchscreen/mcs5000_ts.c Just make sure you request threaded irq with IRQF_ONESHOT. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
