Re: [RFC] Wakeup for PNP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Alan,

On Wed, Mar 03, 2010 at 10:29:09AM -0500, Alan Stern wrote:
> On Tue, 2 Mar 2010, Dmitry Torokhov wrote:
> 
> > > @@ -656,7 +658,7 @@ static struct pnp_device_id pnp_kbd_devi
> > >  };
> > >  
> > >  static struct pnp_driver i8042_pnp_kbd_driver = {
> > > -	.name           = "i8042 kbd",
> > > +	.name           = "i8042-kbd",
> > 
> > Why is this needed? I don't think spaces are more dangerous than a colon
> > which we do use...
> 
> This string becomes the name of a directory in sysfs.  Having a ' '
> character in a directory name just doesn't seem like a good idea; at
> the very least it's likely to confuse shell scripts.  (A ':' character
> is a lot less subject to misinterpretation.)  I could change the '-' to 
> ':' if you prefer.
> 

We have not heard complains about this causing trouble ever since PNP
support was added (so what 5 years at least?). At this point I'd be more
worried about breaking existing users...

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux