[PATCH 0/1] hid-magicmouse: Emulate horizontal scrolling.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This patch is separate from the changes about input device registration,
except for having some context lines in common with Benjamin's patch.  I
found a use case for horizontal scrolling while moving left to right in
an OpenOffice.org spreadsheet, and this gesture seems basic enough to
merit inclusion in the kernel.

Some areas that may deserve revision or more attention before commit:

1) It might make sense to separately commit the parameter for the
acceleration profile.  I didn't do that because they touch the same code
and exporting the module parameter is so few lines.

2) The acceleration profile is faster than the original, which was not
as responsive as my mice with physical scroll wheels.  However, the
horizontal scrolling may be a little too sensitive: I have to be
somewhat careful to only drag vertically, or else it will generate
horizontal scroll events.  This would be fixable using a different
scroll_accel_profile-like array for each direction.  Other potential
solutions (such as heuristics to guess the direction of the swipe)
seemed better left to user space.

3) The initial calculation of num_scroll_accel_profile is not pretty.
It seemed marginally better to calculate it at module load time than
hard-code the default value, but that's debatable.  I don't see a
reasonable way to calculate the default value at compile time.

Michael Poole
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux