Re: [PATCH 3/3] HID: deletion of unused code in hid-magicmouse.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Benjamin Tissoires writes:

>>
>> Well ... I don't see any patch titled "HID: deletion of unused code in
>> hid-magicmouse" neither in my inbox nor in my linux-input@ folder. Could
>> you perhaps please resend?
>>
>> Thanks,
>>
>
> Of course, I attached it. Do I need to send it in mbox format or is it ok ?
>
> Cheers,
> Benjamin

The recommended practice for sending patches is (from
Documentation/SubmittingPatches) "7) No MIME, no links, no compression,
no attachments.  Just plain text."

I'm a bit mystified, though -- if magicmouse_setup_input() is from "the
old implementation", where is the new implementation?  Jiri's
hid/for-next and hid/master trees definitely use the input device that
it sets up.  The "magicmouse_input_mapping" function that shows up at
the end of your patch doesn't exist in those trees.  The reason I didn't
use input_mapping() initially was because it only allows setting up one
input field, and the touch records generate multiple types of events.

Michael Poole
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux