Re: [PATCH] Input: scancode in get/set_keycodes should be unsigned

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dmitry Torokhov wrote:
> On Sun, Feb 28, 2010 at 07:44:32AM +0100, Németh Márton wrote:
>> Hi,
>> Dmitry Torokhov wrote:
>>> The HID layer has some scan codes of the form 0xffbc0000 for logitech
>>> devices which do not work if scancode is typed as signed int, so we need
>>> to switch to unsigned int instead. While at it keycode being signed does
>>> not make much sense either.
>> Are the scan codes and key codes always 4 bytes long? Then the u32 data
>> type could be used to take 16 bit (or 64 bit) processors also into
>> consideration.
>>
> 
> We do not support 16 bit processors and for 64 bit 'unsigned int' is
> still 32 bits.
> 

OK, then:

Acked-by: Márton Németh <nm127@xxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux