On Wed, Feb 17, 2010 at 11:03:08PM +0100, Christian Lamparter wrote: > On Wed, Feb 17, 2010 at 10:40 PM, Dmitry Torokhov > <dmitry.torokhov@xxxxxxxxx> wrote: > > On Feb 17, 2010, at 1:28 PM, Christian Lamparter <chunkeey@xxxxxxxxxxxxxx> > > wrote: > > > >> On Wed, Feb 17, 2010 at 9:52 PM, Dmitry Torokhov > >> <dmitry.torokhov@xxxxxxxxx> wrote: > >>> > >>> Sorry, I was not clear enough. I meant something in works in Linux > >>> software > >>> stack, I was aware that certain router have these buttons already. > >>> > >> > >> wpa_supplicant and hostapd's CLI have this wps_pbc command. > >> It's more a question of: what application will get to receive the event. > > > > Right. So as soon as you have an idea about userspace consumer > > for the event ping me and I'd be glad to add a key definition for the event. > Idea? Be a bit more specific... > > As a matter of fact, there are a few potential consumer in the kernel: > > arm/mach-kirkwood/mv88f6281gtw_ge-setup.c: > .code = KEY_F1, > .gpio = 46, > .desc = "WPS Button(F1)", > .active_low = 1, > > arm/mach-orion5x/wrt350n-v2-setup.c: > .code = KEY_WLAN, > .gpio = 2, > .desc = "WPS Button", > .active_low = 1, > > > > > and there's a lot more "out-off-tree": > https://dev.openwrt.org/browser/trunk/target/linux/ar71xx/files/arch/mips/ar71xx > > mach-tew-632brp.c: > .desc = "wps", > .type = EV_KEY, > .code = BTN_1, > .threshold = 3, > .gpio = TEW_632BRP_GPIO_BTN_WPS, > > carl9170: > input_set_capability(input, EV_KEY, BTN_0); > > > as you can see, people are using BTN_1, BTN_0, F1, WLAN (rfkill?) > as WPS Button substitute. Maybe it would be a good idea to get it right > now! I see, then I will be queueing the patch below... -- Dmitry Input: add KEY_WPS_BUTTON definition The new key definition is supposed to be used for buttons that initiate WiFi Protected Setup sequence: http://en.wikipedia.org/wiki/Wi-Fi_Protected_Setup Signed-off-by: Dmitry Torokhov <dtor@xxxxxxx> --- include/linux/input.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/linux/input.h b/include/linux/input.h index 04416f6..6825308 100644 --- a/include/linux/input.h +++ b/include/linux/input.h @@ -597,6 +597,7 @@ struct input_absinfo { #define KEY_NUMERIC_POUND 0x20b #define KEY_CAMERA_FOCUS 0x210 +#define KEY_WPS_BUTTON 0x211 /* WiFi Protected Setup key */ /* We avoid low common keys in module aliases so they don't get huge. */ #define KEY_MIN_INTERESTING KEY_MUTE -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
