Re: [PATCH 3/4] hid-ntrig.c Split multi and single touch.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 11 Feb 2010, Dmitry Torokhov wrote:

> > +		} else if (nd->emit_ghosts) {
> > +			/* emit filler points if so desired */
> > +			input_event(input, EV_ABS, ABS_MT_TRACKING_ID, i);
> > +			input_event(input, EV_ABS, ABS_MT_POSITION_X, 0);
> > +			input_event(input, EV_ABS, ABS_MT_POSITION_Y, 0);
> > +			input_event(input, EV_ABS, ABS_MT_ORIENTATION, 0);
> > +			input_event(input, EV_ABS, ABS_MT_TOUCH_MAJOR, 0);
> > +			input_event(input, EV_ABS, ABS_MT_TOUCH_MINOR, 0);
> > +			input_mt_sync(input);
> > +		}
> > +	}
> 
> Where's the final input_sync()? And if hid does it for us (I think it does)
> then syncs above are not needed.

Yes, it does, in hidinput_report_event(), after the custom ->event() 
callback has finished.

Thanks a lot Dmitry for beating me looking at the patches, I really 
appreciate that.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux