-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 02/11/10 19:36, Dmitry Torokhov wrote:
> Hi Rafi,
>
> On Thu, Feb 11, 2010 at 07:19:03PM -0500, Rafi Rubin wrote:
>> Added a quirk to enable distinct input devices. The digitizer utilizes
>> three inputs to represent pen, multitouch and a normal touch screen.
>>
>> With the Pen partitioned, it behaves well and does not need special
>> handling.
>>
>> Also, I set names to the input devices to clarify the functions of the
>> various inputs.
>>
>
> Overall looks much nicer (goes for all 4 patches) and reader should be
> able to see what is going on much easier now.
>
> Couple of formatting nits still (I am pretty sure scripts/checkpatch.pl
> warns about these as well):
Fair enough. I ran it through scripts/Lindent for the 4th patch. I guess
that's not as thorough and I should have checked earlier.
>> - if (ret)
>> + if (ret) {
>> kfree (nd);
>
> What about hid_hw_stop()? Overall I'd rather see the standard error
> unwinding path with gotos.
Ok.
>> + if(hidinput->report->field[0]->physical) {
>> + input->name = "N-Trig Touchscreen";
>> + } else {
>> + input->name = "N-Trig MultiTouch";
>> + }
>
> No need for curly braces for single-line statements. Maybe compress to
> ?: statement?
That's an artifact of staging the changes. Oddly enough my original version was just ?:
Rafi
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAkt0pL8ACgkQwuRiAT9o6098awCeLFRkVATyURHEBszR63dvzfWK
B7gAoNevD3DmWK3qgCEGIGgqKGY3f8aU
=2z1B
-----END PGP SIGNATURE-----
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
