On Wed, Feb 10, 2010 at 6:26 PM, Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote: > On Wed, Feb 10, 2010 at 01:13:37PM +0900, Magnus Damm wrote: >> On Tue, Feb 9, 2010 at 6:39 PM, Dmitry Torokhov >> <dmitry.torokhov@xxxxxxxxx> wrote: >> > On Tue, Feb 09, 2010 at 06:16:09PM +0900, Magnus Damm wrote: >> >> From: Magnus Damm <damm@xxxxxxxxxxxxx> >> >> >> >> Update the sh_keysc driver with proper bitmap support V2. >> >> This instead of using a fixed 32-bit integer to keep track >> >> for the key states. With this change in place the driver >> >> supports key pads with more than 32 keys. >> >> >> >> Signed-off-by: Magnus Damm <damm@xxxxxxxxxxxxx> >> >> --- >> >> >> >> Changes since V1: >> >> - ditched the wrapping macros >> >> - use __set_bit() and __clear_bit() >> > >> > Thank you for making the change. It indeed is easier to read than the >> > original since one does not have to go and look up what wrappers are >> > doing. >> >> Yeah, I initially disliked the SH_KEYSC_MAXKEYS that now are sprinkled >> all over the place, but I have to admit that not using wrappers made >> me realize that I should use __set_bit() and __clear_bit() instead of >> the atomic ones. So all good. >> > > BTW, that sh_keysc_map seems to be a holdover from the V1 of the patch > and is not needed anymore. Does the patch below still work for you? Thanks for updating the patch. It still works as expected. Please mark the new patch as V3 if possible so people can tell the difference between the patches. Cheers, / magnus -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
