Re: [PATCH] Fixed bug in single-touch emulation on the Stantum panel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 6 Feb 2010, Stephane Chatty wrote:

> Fixed bug in touchscreen emulation for the Stantum multitouch panel

Hi Stephane,

could you please perhaps provide a little bit more detailed information 
about the nature of the bug this is fixing? It might be useful for people 
looking through changelog.

> Signed-off-by: Stephane Chatty <chatty@xxxxxxx>
> 
> diff -rupN a/drivers/hid/hid-stantum.c b/drivers/hid/hid-stantum.c
> --- a/drivers/hid/hid-stantum.c	2010-02-06 14:59:57.000000000 +0100
> +++ b/drivers/hid/hid-stantum.c	2010-02-06 15:00:36.000000000 +0100
> @@ -16,7 +16,7 @@
>  #include <linux/hid.h>
>  #include <linux/module.h>
>  
> -MODULE_VERSION("1.00");
> +MODULE_VERSION("1.01");

Are you planning to maintain this numbering, btw? Usually people forget to 
update it :)

>  MODULE_AUTHOR("Stephane Chatty <chatty@xxxxxxx>");
>  MODULE_DESCRIPTION("Stantum HID multitouch panels");
>  MODULE_LICENSE("GPL");
> @@ -147,7 +147,6 @@ static void stantum_filter_event(struct 
>  
>  	input_mt_sync(input);
>  	sd->valid = false;
> -	sd->first = false;
>  
>  	/* touchscreen emulation */
>  	if (sd->first) {
> @@ -158,6 +157,7 @@ static void stantum_filter_event(struct 
>  		input_event(input, EV_ABS, ABS_X, sd->x);
>  		input_event(input, EV_ABS, ABS_Y, sd->y);
>  	}
> +	sd->first = false;
>  }
>  

Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux