Re: [PATCH] input/misc: rotary-encoder: Set gpio direction

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 08, 2010 at 04:18:23PM -0800, Dmitry Torokhov wrote:
> On Monday 08 February 2010 02:12:06 pm Daniel Mack wrote:
> > On Mon, Feb 08, 2010 at 09:03:50PM +0000, Andrew Clayton wrote:
> > > While trying to get a rotary encoder working under a beagle board using
> > > the drivers/input/misc/rotary-encoder.c driver, we found that even with
> > > the right pin mux settings configured through
> > > /sys/kernel/debug/omap_mux/*, i.e INPUT_PULLUP and MODE4, the
> > > gpio_get_value() functions only ever returned 1.
> > >
> > > By explicitly calling gpio_direction_input() after each requested gpio,
> > > the driver started working and started returning correct input events.
> > >
> > > The following is the patch that works for us. What do you think?
> > 
> > Yep, that looks good to me, thanks!
> > 
> > Acked-by: Daniel Mack <daniel@xxxxxxxx>
> 
> .33 material or hold off till .34?

Hmm, it doesn't fix any existing upstream platform, so I think it should
be fine for .34.

Thanks,
Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux