Re: [PATCH] HID: Major update to N-Trig touchscreen

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



OK, this kind code just makes me want to poke my eyes with a fork... 5
times...

Terribly sorry about the ensuing spillage of guts, I guess I owe you a pair of glasses.

Seriously, either factor it out into a nice function, or say "screw it"
to the 80 columt limit, or maybe both. Anything but this.

I fully agree with your sentiment and am shamed for not reading it carefully after passing it through the Lindent script.

Unfortunately I had my editor configured for a tab width of 3 for C, though I'm not even sure why. And thus failed to notice the silly degree of indentation in the code.



Anyway, if you're still capable of reading this and the patch, I would appreciate more feedback now that I've refactored it a bit.

Rafi
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux