Hi,
Alberto Panizzo writes:
> > > + irq = platform_get_irq(pdev, 0);
> > > + if (irq < 0) {
> > > + dev_err(&pdev->dev, "failed to get keypad irq\n");
> > > + return -ENXIO;
> > > + }
> > >
> > This should be -ENODEV.
> >
> Lot of reference keyboard driver use -ENXIO..
> May should be better: return irq ?
>
Yes, of course. If a function returns an error code that should be
promoted to the caller instead of inventing a new error code.
Lothar Waßmann
--
___________________________________________________________
Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Geschäftsführer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996
www.karo-electronics.de | info@xxxxxxxxxxxxxxxxxxx
___________________________________________________________
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
