[ Adding Pekka (the author of the patch that added this quirk for AF9016) to
CC ... ]
On Wed, 13 Jan 2010, Jiri Slaby wrote:
> Let's ignore the device altogether by HID layer. It's handled by
> dvb-usb-remote driver properly already.
>
> By now, FULLSPEED_INTERVAL quirk was used. It probably made things
> better, but the remote ctrl was still a perfect X killer. This was
> the last user of the particular quirk. So remove the quirk as well.
>
> With input going through dvb-usb-remote, the remote works
> perfectly.
>
> Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
> Cc: Jiri Kosina <jkosina@xxxxxxx>
> ---
> drivers/hid/usbhid/hid-core.c | 8 --------
> drivers/hid/usbhid/hid-quirks.c | 2 +-
> include/linux/hid.h | 1 -
> 3 files changed, 1 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c
> index e2997a8..36a1561 100644
> --- a/drivers/hid/usbhid/hid-core.c
> +++ b/drivers/hid/usbhid/hid-core.c
> @@ -938,14 +938,6 @@ static int usbhid_start(struct hid_device *hid)
>
> interval = endpoint->bInterval;
>
> - /* Some vendors give fullspeed interval on highspeed devides */
> - if (hid->quirks & HID_QUIRK_FULLSPEED_INTERVAL &&
> - dev->speed == USB_SPEED_HIGH) {
> - interval = fls(endpoint->bInterval*8);
> - printk(KERN_INFO "%s: Fixing fullspeed to highspeed interval: %d -> %d\n",
> - hid->name, endpoint->bInterval, interval);
> - }
> -
> /* Change the polling interval of mice. */
> if (hid->collection->usage == HID_GD_MOUSE && hid_mousepoll_interval > 0)
> interval = hid_mousepoll_interval;
> diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
> index 38773dc..788d9a3 100644
> --- a/drivers/hid/usbhid/hid-quirks.c
> +++ b/drivers/hid/usbhid/hid-quirks.c
> @@ -41,7 +41,7 @@ static const struct hid_blacklist {
> { USB_VENDOR_ID_SAITEK, USB_DEVICE_ID_SAITEK_RUMBLEPAD, HID_QUIRK_BADPAD },
> { USB_VENDOR_ID_TOPMAX, USB_DEVICE_ID_TOPMAX_COBRAPAD, HID_QUIRK_BADPAD },
>
> - { USB_VENDOR_ID_AFATECH, USB_DEVICE_ID_AFATECH_AF9016, HID_QUIRK_FULLSPEED_INTERVAL },
> + { USB_VENDOR_ID_AFATECH, USB_DEVICE_ID_AFATECH_AF9016, HID_QUIRK_IGNORE },
Hmm, why do we keep HID_QUIRK_IGNORE anyway, when we already have generic
hid_ignore_list[]?
We don't set it for any device in the current codebase any more.
Thanks,x
--
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
