On Mon, Jan 11, 2010 at 11:54:05AM +0530, Hiremath, Vaibhav wrote: > > > -----Original Message----- > > From: Hiremath, Vaibhav > > Sent: Thursday, November 19, 2009 8:17 PM > > To: linux-input@xxxxxxxxxxxxxxx > > Cc: linux-omap@xxxxxxxxxxxxxxx; Hiremath, Vaibhav > > Subject: [PATCH 2/3] Input:TouchScreen: Introduce TSC2004 driver > > support > > > > From: Vaibhav Hiremath <hvaibhav@xxxxxx> > > > > Signed-off-by: Vaibhav Hiremath <hvaibhav@xxxxxx> > > --- > > drivers/input/touchscreen/Kconfig | 11 + > > drivers/input/touchscreen/Makefile | 1 + > > drivers/input/touchscreen/tsc2004.c | 525 > > +++++++++++++++++++++++++++++++++++ > > include/linux/i2c/tsc2004.h | 17 ++ > > 4 files changed, 554 insertions(+), 0 deletions(-) > > create mode 100644 drivers/input/touchscreen/tsc2004.c > > create mode 100644 include/linux/i2c/tsc2004.h > > > [Hiremath, Vaibhav] Dmitry, > > Any update on this? This driver support is important for AM3517EVM, can we merge this patch? > Hi Hiremath, I looked over the 2 drivers again and I still think that they are too much alike to warrant splitting them into 2. The only thing that you need is provide tsc2004-specific variant of tsc2007_read_values and add tsc2007-specific variant of tsc2004_prepare_for_reading. Once the drivers start really diverging we may revisit this issue. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
