On Thursday 07 January 2010 11:21:05 am Bastian Blank wrote: > On Thu, Jan 07, 2010 at 11:06:30AM -0800, Dmitry Torokhov wrote: > > On Thursday 07 January 2010 10:29:36 am Bastian Blank wrote: > > > + struct wacom_features *features = (void *)id->driver_info; > > > > What is this cast for? > > driver_info is an integer. > > > > + if (!features) > > > + features = get_wacom_feature(id); > > > > In which cases driver would not have driver_info set up? > > At this stage in the patchset, non have. Later the driver defined ids > have, the user defined have not. > Ah, OK. Frankly I would fold patches 2-7 into one since it is one logical change. While you are at it, any chance of constifying wacom_features? Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
