On Thu 7 Jan 2010 12:07, Dmitry Torokhov pondered: > On Thu, Jan 07, 2010 at 11:46:15AM -0500, Mike Frysinger wrote: > > On Thu, Jan 7, 2010 at 11:16, Robin Getz wrote: > > > On Thu 7 Jan 2010 02:31, Dmitry Torokhov pondered: > > >> On Thu, Jan 07, 2010 at 02:18:22AM -0500, Mike Frysinger wrote: > > >> > From: Michael Hennerich <michael.hennerich@xxxxxxxxxx> > > >> > > > >> > Drop the simple fancy sysfs hooks for the aux GPIOs and expose these via > > >> > the gpiolib interface so that other drivers can use them. > > >> > > >> Would not that mess up current users (if any) that may rely on the > > >> existing sysfs attributes? > > > > > > We have talked to the existing users of this (that we know of), and they > > > agreed that doing things the "standard" way with gpiolib is the better way to > > > move forward on things. > > > > there is a standard sysfs interface for accessing gpios already too > > which this change allows people to utilize > > Using (and providing) standard interfaces are laudible goal, however > that does not mean we can screw existing users over. Now Robin sais that > you talked to users (at least some) and this being an embedded platform > taht might be OK but generally sysfs is userspace interface and thus are > not to be changed lightly, only extended. I agree - but in this case - the driver in question has only been in mainline a few kernel versions (since March'09). http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=history;f=drivers/input/touchscreen/ad7879.c;hb=HEAD And the only feedback we have gotten was to make this change - so people could use the gpio in other drivers more than requests about userspace... -Robin -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
