Re: [PATCH] input/evdev: Be less aggressive about sending SIGIO notifies

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 04, 2010 at 04:08:17PM -0500, Adam Jackson wrote:
> When using realtime signals, we'll enqueue one signal for every event.
> This is unfortunate, because (for example) keyboard presses are three
> events: key, msc scancode, and syn.  They'll be enqueued fast enough in
> kernel space that all three events will be ready to read by the time
> userspace runs, so the first invocation of the signal handler will read
> all three events, but then the second two invocations still have to run
> to do no work.
> 
> Instead, only send the SIGIO notification on syn events.  This is a
> slight abuse of SIGIO semantics, in principle it ought to fire as soon
> as any events are readable.  But it matches evdev semantics, which is
> more important since SIGIO is rather vaguely defined to begin with.

Makes sense, will apply. It might mess up evtest slightly (if a driver
author forgets using input_sync() ) but we have evbug for true hardcore
debugging :)

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux