Hi Hartley, On Mon, Dec 21, 2009 at 01:01:01PM -0500, H Hartley Sweeten wrote: > ep93xx_keypad.c: cleanup and use matrix_keypad helpers > > 1) use struct matrix_keymap_data to supply the keymap from the platform code > and use matrix_keypad_build_keymap() to initialize the keymap I;d prefer this one split out. Also, is there any in-kernel users and will they be converted to the new format of platform data. > 2) namespace sanitize the local defines > 3) cleanup the interrupt handler to make it more understandable > 4) allocate the keycode matrix at run time What is the point given that the size of the keymap is still constant with your patch. And even if it was dynamic just stick it at the end of struct ep93xx_keypad as unsigned short keycodes[] and allocate in one shot. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
