Hi Uwe, On Tue, Dec 15, 2009 at 11:10:28AM +0100, Uwe Kleine-König wrote: > Hi Dmitry, > > I squashed your changes into this patch, restored my indention style and > simplified error handling in mc13783_ts_probe to assign ret = -ENOMEM > once at the start of the function instead of each error branch. I prefer to have error defined right before we jump because it allows reader to see explicitely set error condition instead of having to verify if earlier code set it properly; it also forces you to set error conditions on every error branch properly (if you forget while adding a new one compiler will warn you about uninitialized variable), but I won't insist. > > In the meantime the changes to mc13783-core are merged in Linus' tree, > so it can go via your's. > It settled then. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
