Hi Martin, On Sun, Dec 13, 2009 at 02:25:25PM +0100, Marjan Fojkar wrote: > From: Marjan Fojkar <marjan@xxxxxxxx> > > The patch removes msleep call from atomic context. To achieve that, the driver > PSIF leaves atomic context before the call in order to enable interrupts to be > performed safely. When the call is done, the driver jumps back to atomic context. > Yes, msleep is not allowed in atomic context, however serio's write() method is supposed to be callable from atomic context so msleep is not available there period. I scanned the datasheet quickly and did not see any restriction on the frequency of reading status register so I think we should do what i8042 driver does - udelay(50). Hans-Christian? -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html