Re: [linux-pm] [PATCH v2 1/2] Input: gpio-keys - allow platform to specify exact irq flags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 30, 2009 at 09:59:06PM +0100, Ferenc Wagner wrote:
> Mika Westerberg <mika.westerberg@xxxxxx> writes:
> 
> > If it suits you, I would go with the "can_disable" -field in the
> > struct gpio_keys_button. This way it should be possible to extend
> > gpio-keys in future to support multiple buttons sharing the single IRQ
> > and it also works for us.
> 
> Why not simply release the corresponding IRQ?  No new fields are needed
> in the platform data, you don't even have to change the IRQ flags.  Or
> do I miss something again?

It would work but with one unpleasant possibility - of you release IRQ
some other device might "steal" it. I don't think it is a good style for
a device to fail due to resources conflict if it was working to begin
with.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux