Hi, thanks for the feedback. I'll soon resend the first two patches as properly formatted ones. (git format-patch this time) About the third one adding a "trigger_mapping" option: When reusing the dpad_mapping field to add new options to it are you thinking about turning it into a numerical constant that goes 0-1-2-3 for all mapping combinations? It does not needlessly break user space's configuration scripts, however the name and semantics of the option are more complicated. In particular the semantics of the existing dpad_mapping option is a bit strange already, since it only act on "unknown" devices / do not act on known devices. Which I'm not sure works anyway? My devices only started to work when I registered their vendor and product id. Why not allow overriding mappings of a known device? Cheers, Nicolas On 2009-11-26, at 07:04 , Dmitry Torokhov wrote: > Hi Nicolas, > > On Sun, Nov 22, 2009 at 09:55:38AM +0100, Nicolas Léveillé wrote: >> Part one of three patches against latest head of >> git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git >> > > It looks like your mailer wrapped the mails so the patches won't apply. > Please resend. Also, instead of creating a new field maybe chnage > dpad_mapping to be a bitmap of options? > > Thanks. > > -- > Dmitry > > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
