Mika Westerberg <ext-mika.1.westerberg@xxxxxxxxx> writes:
> Added new field to struct gpio_keys_button: irqflags which can
> be used to specify exact irqflags the platform wants. If not specified,
> it defaults to: IRQF_SHARED | IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING.
>
> --- a/drivers/input/keyboard/gpio_keys.c
> +++ b/drivers/input/keyboard/gpio_keys.c
> @@ -106,10 +107,14 @@ static int __devinit gpio_keys_setup_key(struct device *dev,
> goto fail3;
> }
>
> - error = request_irq(irq, gpio_keys_isr,
> - IRQF_SHARED |
> - IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
> - desc, bdata);
> + if (button->irqflags == 0) {
> + irqflags = IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING |
> + IRQF_SHARED;
> + } else {
> + irqflags = button->irqflags;
> + }
> +
> + error = request_irq(irq, gpio_keys_isr, irqflags, desc, bdata);
> if (error) {
> dev_err(dev, "Unable to claim irq %d; error %d\n",
> irq, error);
Hi Mika,
linux/interrupt.h says:
When requesting an interrupt without specifying a IRQF_TRIGGER, the
setting should be assumed to be "as already configured", which may
be as per machine or firmware initialisation.
So I'm not sure it's a good idea to exclude 0 from the possible irqflag
values.
--
Regards,
Feri.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
