Re: [PATCH 1/2] Input: gpio-keys: allow drivers to specify whether IRQ can be shared

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Mika,

On Thu, Nov 19, 2009 at 09:23:45AM +0200, Mika Westerberg wrote:
> Added new field to struct gpio_keys_button: exclusive_irq which can
> be used to specify whether driver wants to have exclusive access to
> IRQ or can it be shared. By default IRQs for gpio-keys are shareable.
> 

I think the idea makes sense with one exception - why limit just to
sharing and not let platform specify the exact IRQ flags it needs,
defaulting to IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | IRQF_SHARED?

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux